Subham-KRLX commented on code in PR #3960:
URL: https://github.com/apache/polaris/pull/3960#discussion_r2979089082
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -121,10 +125,12 @@ private void initializeForRealm(
metaStoreManagerMap.put(realmId, metaStoreManager);
}
- public DatasourceOperations getDatasourceOperations() {
+ public DatasourceOperations getDatasourceOperations(RealmContext
realmContext) {
DatasourceOperations databaseOperations;
try {
- databaseOperations = new DatasourceOperations(dataSource.get(),
relationalJdbcConfiguration);
+ DataSource resolvedDs =
+ dataSourceResolver.resolve(realmContext,
DataSourceResolver.StoreType.METASTORE);
Review Comment:
@dimas-b You are right that the previous version reused the same DataSource
for all operations I have updated the PR to fully implement the foundation for
workload isolation: JdbcMetaStoreManagerFactory now resolves three distinct
DataSource instances (for METASTORE, METRICS, and EVENTS) and provides them as
isolated metastoreOps, metricsOps, and eventOps to the persistence
implementation. This makes the StoreType parameter meaningful and establishes
the connection pool separation discussed as a high priority earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
