jbonofre commented on code in PR #4046:
URL: https://github.com/apache/polaris/pull/4046#discussion_r2979098465


##########
client/python/apache_polaris/cli/command/setup.py:
##########
@@ -1225,6 +1243,12 @@ def _create_namespaces(
                     logger.info(
                         f"Namespace '{ns_name}' created successfully in 
catalog '{catalog_name}'."
                     )
+                    existing_namespaces.add(ns_name)
+                except ConflictException:
+                    logger.info(
+                        f"Namespace '{ns_name}' already exists in catalog 
'{catalog_name}'."
+                    )
+                    existing_namespaces.add(ns)

Review Comment:
   I think it should be `ns_name` here as `ns` is actually the loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to