Subham-KRLX commented on code in PR #3960:
URL: https://github.com/apache/polaris/pull/3960#discussion_r2986283686
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -103,15 +107,22 @@ private void initializeForRealm(
// determine schemaVersion once per realm
final int schemaVersion =
JdbcBasePersistenceImpl.loadSchemaVersion(
- datasourceOperations,
+ metastoreOps,
realmConfig.getConfig(BehaviorChangeConfiguration.SCHEMA_VERSION_FALL_BACK_ON_DNE));
+ DatasourceOperations metricsOps =
+ getDatasourceOperations(realmContext,
DataSourceResolver.StoreType.METRICS);
Review Comment:
Agreed I removed dataSourceResolverType() from the core
RelationalJdbcConfiguration and moved JdbcCdiProducers to the runtime-common
module to keep the persistence layer decoupled from configuration details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
