dimas-b opened a new pull request, #4056:
URL: https://github.com/apache/polaris/pull/4056

   * Convert the old `IndexElem` class to the root of the `Index.Element` class 
hierarchy
   
   * Consolidate equals/hashCode logic for all sub-classes in `IndexElem`
   
   * Note: Internal index elements having `null` values are not comparable in 
runtime. Attempts to invoke `.equals()` or `.hashCode()` on them will result in 
`NullPointerException`.
   
   * Note: Internal index elements having `null` values are never actually 
compared in runtime.
   
   Fixes #4049
   
   <!--
   ๐Ÿ“ Describe what changes you're proposing, especially breaking or user-facing 
changes. 
   ๐Ÿ“– See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
   -->
   
   ## Checklist
   - [ ] ๐Ÿ›ก๏ธ Don't disclose security issues! (contact [email protected])
   - [ ] ๐Ÿ”— Clearly explained why the changes are needed, or linked related 
issues: Fixes #
   - [ ] ๐Ÿงช Added/updated tests with good coverage, or manually tested (and 
explained how)
   - [ ] ๐Ÿ’ก Added comments for complex logic
   - [ ] ๐Ÿงพ Updated `CHANGELOG.md` (if needed)
   - [ ] ๐Ÿ“š Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to