joyhaldar commented on code in PR #4050:
URL: https://github.com/apache/polaris/pull/4050#discussion_r2992615984
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -210,6 +213,30 @@ public static ConnectionConfigInfoDpo
fromConnectionConfigInfoModelWithSecrets(
hiveConfigModel.getWarehouse(),
null /*Service Identity Info*/);
break;
+ case BIGQUERY:
+ BigQueryMetastoreConnectionConfigInfo bigqueryConfigModel =
+ (BigQueryMetastoreConnectionConfigInfo)
connectionConfigurationModel;
+ authenticationParameters =
+
AuthenticationParametersDpo.fromAuthenticationParametersModelWithSecrets(
+ bigqueryConfigModel.getAuthenticationParameters(),
secretReferences);
+ String bigqueryUri =
+ bigqueryConfigModel.getUri() != null
Review Comment:
Done. I have moved the default URI to a public constant in
`BigQueryMetastoreConnectionConfigInfoDpo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
