flyrain commented on code in PR #4050:
URL: https://github.com/apache/polaris/pull/4050#discussion_r3019156955
##########
spec/polaris-management-service.yml:
##########
@@ -965,6 +967,44 @@ components:
warehouse:
type: string
description: The warehouse location for the hive catalog.
+
+ BigQueryMetastoreConnectionConfigInfo:
+ type: object
+ description: Configuration necessary for connecting to a BigQuery
Metastore Catalog
+ allOf:
+ - $ref: '#/components/schemas/ConnectionConfigInfo'
+ properties:
+ warehouse:
+ type: string
+ description: The GCS bucket path for the catalog (e.g.,
gs://bucket-name)
+ gcpProjectId:
+ type: string
+ description: The GCP project ID
+ gcpLocation:
+ type: string
+ description: The GCP location (default = us)
+ listAllTables:
+ type: boolean
+ description: Whether to list all tables (default = true)
+ impersonateServiceAccount:
+ type: string
+ description: Service account email to impersonate
+ impersonateLifetimeSeconds:
+ type: integer
+ description: Token lifetime in seconds for impersonation (default =
3600)
+ impersonateScopes:
+ type: array
+ items:
+ type: string
+ description: OAuth scopes for impersonation (default =
cloud-platform)
+ impersonateDelegates:
+ type: array
+ items:
+ type: string
+ description: Delegation chain for impersonation
Review Comment:
How often does the BQMS config surface change? For example, when new fields
are introduced or existing fields are updated. Locking every field into the
spec creates a maintenance burden, since each upstream change requires a
Polaris spec PR, client regeneration, and a new release.
Instead, we could consider using a bag of open properties to keep the model
more flexible.
```
properties:
type: object
additionalProperties:
type: string
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
