flyrain commented on code in PR #4091:
URL: https://github.com/apache/polaris/pull/4091#discussion_r3034703540
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -849,14 +855,14 @@ private LoadTableResponse.Builder
buildLoadTableResponseWithDelegationCredential
return responseBuilder;
}
- if (baseCatalog instanceof IcebergCatalog
+ if (!isFederated
Review Comment:
> If catalogFactory().createCallContextCatalog() returns something over than
IcebergCatalog, the "previous" code would gracefully fall through to the else
branch,
I don't think that's a graceful behavior. The `else` branch is for federated
catalogs, `catalogFactory().createCallContextCatalog()` return a non federated
catalog, the behavior is completely wrong. After this change, the code fail
fast, maybe not the best way now, but better. We can continue to refactor to
make it better in followup PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
