nandorKollar commented on PR #4064: URL: https://github.com/apache/polaris/pull/4064#issuecomment-4197096222
> Thanks — I walked through the latest revision and I don’t see an obvious correctness blocker after the event-bus address fix. > > The main thing I’d still like to see is focused regression coverage for the new behavior introduced here: > > * a listener configured with enabledEventTypes only receives that subset; > * when no listener is registered for a type, we really skip the PolarisEvent creation / dispatch path; > * the deprecated polaris.event-listener.type fallback still behaves as expected alongside the new multi-listener config. > > This PR is changing both config semantics and the dispatch fast path, so having those cases pinned down in tests would make future refactors a lot safer. Thanks @flyingImer for the review. I added some more test coverage, would you mind have a look at the latest version, and share your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
