adutra commented on PR #4061: URL: https://github.com/apache/polaris/pull/4061#issuecomment-4206407332
Worth noting: this PR introduces a new `TaskContextPropagator` bean. The bean is functionally equivalent to a custom `org.eclipse.microprofile.context.spi.ThreadContextProvider`. I wonder if it wouldn't be cleaner to just wire up a custom `ThreadContextProvider` instead of providing an equivalent class that must be invoked explicitly at the beginning of each task. The custom `ThreadContextProvider` would still require to clear `ThreadContext.CDI` + `@ActivateRequestContext` + manual population of beans. So it wouldn't look radically different for sure, but we would at least benefit from implicit execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
