nandorKollar commented on code in PR #4064:
URL: https://github.com/apache/polaris/pull/4064#discussion_r3071540114
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventListeners.java:
##########
@@ -31,23 +31,68 @@
import jakarta.enterprise.inject.Any;
import jakarta.enterprise.inject.Instance;
import jakarta.inject.Inject;
+import java.util.BitSet;
+import java.util.EnumSet;
import java.util.HashSet;
-import java.util.Set;
import org.apache.polaris.service.events.listeners.PolarisEventListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
@ApplicationScoped
public class PolarisEventListeners {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(PolarisEventListeners.class);
+
@Inject EventBus eventBus;
@Inject @Any Instance<PolarisEventListener> eventListeners;
@Inject PolarisEventListenerConfiguration configuration;
+ private final BitSet eventsByType = new
BitSet(PolarisEventType.values().length);
Review Comment:
Makes sense to me, as EnumSet is implemented as a bit vector, the complexity
of a lookup should be the same for both. @adutra what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
