nandorKollar commented on code in PR #4050:
URL: https://github.com/apache/polaris/pull/4050#discussion_r3091778864
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/hadoop/HadoopConnectionConfigInfoDpo.java:
##########
@@ -51,7 +51,8 @@ public HadoopConnectionConfigInfoDpo(
@JsonProperty(value = "serviceIdentity", required = false) @Nullable
ServiceIdentityInfoDpo serviceIdentityInfo,
@JsonProperty(value = "warehouse", required = false) @Nullable String
remoteCatalogName) {
- super(ConnectionType.HADOOP.getCode(), uri, authenticationParameters,
serviceIdentityInfo);
+ super(
+ ConnectionType.HADOOP.getCode(), uri, authenticationParameters,
serviceIdentityInfo, null);
Review Comment:
nit: I think we can spare adding these ugly 'null' parameters in the super
calls. We can overload the public constructor of `ConnectionConfigInfoDpo` like
this:
```
public ConnectionConfigInfoDpo(
@JsonProperty(value = "connectionTypeCode", required = true) int
connectionTypeCode,
@JsonProperty(value = "uri", required = true) @Nonnull String uri,
@JsonProperty(value = "authenticationParameters", required = true)
@Nullable
AuthenticationParametersDpo authenticationParameters,
@JsonProperty(value = "serviceIdentity", required = false)
@Nullable
ServiceIdentityInfoDpo serviceIdentity,
@JsonProperty(value = "properties", required = false) @Nullable
Map<String, String> properties) {
this(connectionTypeCode, uri, authenticationParameters, serviceIdentity,
true, properties);
}
public ConnectionConfigInfoDpo(
@JsonProperty(value = "connectionTypeCode", required = true) int
connectionTypeCode,
@JsonProperty(value = "uri", required = true) @Nonnull String uri,
@JsonProperty(value = "authenticationParameters", required = true)
@Nullable
AuthenticationParametersDpo authenticationParameters,
@JsonProperty(value = "serviceIdentity", required = false) @Nullable
ServiceIdentityInfoDpo serviceIdentity) {
this(connectionTypeCode, uri, authenticationParameters, serviceIdentity,
true, null);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
