snazy commented on code in PR #4382:
URL: https://github.com/apache/polaris/pull/4382#discussion_r3199050471
##########
runtime/server/build.gradle.kts:
##########
@@ -54,6 +54,8 @@ dependencies {
exclude(group = "com.google.protobuf", module = "protobuf-java-util")
}
implementation("io.quarkus:quarkus-container-image-docker")
+
+
"quarkusProdRuntimeClasspathConfigurationDeployment"("io.quarkus:quarkus-test-common")
Review Comment:
This adds a test dependency to the production deployment, which is IMO not
great.
##########
runtime/server/build.gradle.kts:
##########
@@ -54,6 +54,8 @@ dependencies {
exclude(group = "com.google.protobuf", module = "protobuf-java-util")
}
implementation("io.quarkus:quarkus-container-image-docker")
+
+
"quarkusProdRuntimeClasspathConfigurationDeployment"("io.quarkus:quarkus-test-common")
Review Comment:
This adds a test dependency to the production deployment, which is IMO not
great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
