snazy commented on code in PR #4396:
URL: https://github.com/apache/polaris/pull/4396#discussion_r3217222714
##########
runtime/service/src/test/java/org/apache/polaris/service/admin/PolarisAdminServiceTest.java:
##########
@@ -768,4 +774,41 @@ private void setupSuccessfulNamespaceResolution(
eq(ResolvedPathKey.of(List.of(namespace.levels()),
PolarisEntityType.NAMESPACE))))
.thenReturn(resolvedPathWrapper);
}
+
+ @Test
+ void testResetCredentialsClientIdCollision() {
Review Comment:
I think, this test belongs into the super class to have all backends covered.
For NoSql, [this call to
.put()](https://github.com/apache/polaris/blob/c6d966d6a701e356284671d81d5ce1af94bf8e7e/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/mutation/PrincipalMutations.java#L160)
should return `true`. If it returns `false`, the client-id is a duplicate.
It's okay to just fail hard there in that case (`false`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
