dimas-b commented on code in PR #4414:
URL: https://github.com/apache/polaris/pull/4414#discussion_r3236264966
##########
persistence/nosql/persistence/maintenance/api/src/main/java/org/apache/polaris/persistence/nosql/maintenance/api/MaintenanceService.java:
##########
@@ -35,10 +36,14 @@ public interface MaintenanceService {
*
* @param maintenanceRunSpec define the mandatory run-specification, see
{@link
* #buildMaintenanceRunSpec()}
+ * @param overrideRunId optional run ID of the currently unfinished
maintenance run that shall be
+ * superseded
* @return information about the maintenance run
+ * @throws MaintenanceRunInProgressException if the latest maintenance run
has not finished and
+ * {@code overrideRunId} is empty or does not match that latest
unfinished run
*/
@NonNull MaintenanceRunInformation performMaintenance(
- @NonNull MaintenanceRunSpec maintenanceRunSpec);
+ @NonNull MaintenanceRunSpec maintenanceRunSpec, @NonNull OptionalLong
overrideRunId);
Review Comment:
suggestion: `overrideRunId` -> `supersededRunId`
##########
persistence/nosql/persistence/maintenance/api/src/main/java/org/apache/polaris/persistence/nosql/maintenance/api/MaintenanceService.java:
##########
@@ -35,10 +36,14 @@ public interface MaintenanceService {
*
* @param maintenanceRunSpec define the mandatory run-specification, see
{@link
* #buildMaintenanceRunSpec()}
+ * @param overrideRunId optional run ID of the currently unfinished
maintenance run that shall be
+ * superseded
* @return information about the maintenance run
+ * @throws MaintenanceRunInProgressException if the latest maintenance run
has not finished and
+ * {@code overrideRunId} is empty or does not match that latest
unfinished run
*/
@NonNull MaintenanceRunInformation performMaintenance(
- @NonNull MaintenanceRunSpec maintenanceRunSpec);
+ @NonNull MaintenanceRunSpec maintenanceRunSpec, @NonNull OptionalLong
overrideRunId);
Review Comment:
suggestion: `overrideRunId` -> `supersededRunId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
