dimas-b commented on code in PR #3699:
URL: https://github.com/apache/polaris/pull/3699#discussion_r3243199589
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TreeMapTransactionalPersistenceImpl.java:
##########
@@ -532,24 +530,16 @@ public void deletePrincipalSecretsInCurrentTxn(
/** {@inheritDoc} */
@Override
- public @Nullable <T extends PolarisStorageConfigurationInfo>
- PolarisStorageIntegration<T> createStorageIntegrationInCurrentTxn(
- @Nonnull PolarisCallContext callCtx,
- long catalogId,
- long entityId,
- PolarisStorageConfigurationInfo polarisStorageConfigurationInfo) {
- return storageIntegrationProvider.getStorageIntegrationForConfig(
- polarisStorageConfigurationInfo);
- }
-
- /** {@inheritDoc} */
- @Override
- public @Nullable <T extends PolarisStorageConfigurationInfo>
- PolarisStorageIntegration<T> loadPolarisStorageIntegrationInCurrentTxn(
- @Nonnull PolarisCallContext callCtx, @Nonnull PolarisBaseEntity
entity) {
- PolarisStorageConfigurationInfo storageConfig =
- BaseMetaStoreManager.extractStorageConfiguration(getDiagnostics(),
entity);
- return
storageIntegrationProvider.getStorageIntegrationForConfig(storageConfig);
+ public @Nullable PolarisStorageIntegration
createStorageIntegrationInCurrentTxn(
+ @Nonnull PolarisCallContext callCtx,
+ long catalogId,
+ long entityId,
+ PolarisStorageConfigurationInfo polarisStorageConfigurationInfo) {
+ // No-op in OSS: the storage integration is resolved at credential-vending
time via
+ //
PolarisStorageIntegrationProvider.getStorageIntegration(resolvedEntityPath).
This hook
+ // remains available for custom deployments that need to allocate/lease
external state
+ // atomically with the catalog-creation transaction.
+ return null;
Review Comment:
pls ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
