dimas-b commented on code in PR #4431:
URL: https://github.com/apache/polaris/pull/4431#discussion_r3250098880
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/ModelIdempotencyRecord.java:
##########
@@ -42,46 +42,36 @@ public interface ModelIdempotencyRecord extends
Converter<IdempotencyRecord> {
String TABLE_NAME = "idempotency_records";
- // Logical tenant / realm identifier.
String REALM_ID = "realm_id";
- // Client-provided idempotency key.
String IDEMPOTENCY_KEY = "idempotency_key";
- // Logical operation type (e.g. commit-table).
String OPERATION_TYPE = "operation_type";
- // Normalized identifier of the affected resource.
String RESOURCE_ID = "resource_id";
- // Final HTTP status code once the operation is completed (null while
in-progress).
+ // Hash of caller principal identity bound to the reservation.
+ // Compared on replay to prevent cross-principal cache hits.
+ String PRINCIPAL_HASH = "principal_hash";
+
String HTTP_STATUS = "http_status";
- // Optional error subtype for failures.
String ERROR_SUBTYPE = "error_subtype";
- // Short serialized representation of the response body.
+
String RESPONSE_SUMMARY = "response_summary";
- // Serialized representation of response headers.
- String RESPONSE_HEADERS = "response_headers";
- // Timestamp when the operation was finalized (null while in-progress).
String FINALIZED_AT = "finalized_at";
- // Timestamp when the record was created.
String CREATED_AT = "created_at";
- // Timestamp when the record was last updated.
String UPDATED_AT = "updated_at";
- // Timestamp for the last heartbeat update (null if no heartbeat recorded).
String HEARTBEAT_AT = "heartbeat_at";
- // Identifier of the executor that owns the in-progress record (null if not
owned).
String EXECUTOR_ID = "executor_id";
- // Expiration timestamp after which the record can be considered
stale/purgeable.
String EXPIRES_AT = "expires_at";
Review Comment:
I do not mind keeping or deleting these comments, but IMHO the value of
these comments is pretty low: their meaning is deducible from field names.
Specifying behaviour here is not the ideal place, because there's no logic
in this code area. Logic for processing the values for these columns exists
somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
