snazy commented on code in PR #4501:
URL: https://github.com/apache/polaris/pull/4501#discussion_r3271553293
##########
.github/renovate.json5:
##########
@@ -107,6 +107,17 @@
matchManagers: ["github-actions"],
matchPackageNames: ["python"],
enabled: false
+ },
+ // Scala 2.12 and 2.13 are not compatible
+ // Ensure that Renovate does not "upgrade" from 2.12 to 2.13
+ {
+ matchManagers: ["gradle"],
+ matchPackageNames: [
+ "org.scala-lang:scala-reflect",
+ "org.scala-lang:scala-library",
+ ],
Review Comment:
Probably fine to simplify to
```suggestion
matchPackageNames: [ "org.scala-lang:*" ],
```
##########
.github/renovate.json5:
##########
@@ -107,6 +107,17 @@
matchManagers: ["github-actions"],
matchPackageNames: ["python"],
enabled: false
+ },
+ // Scala 2.12 and 2.13 are not compatible
+ // Ensure that Renovate does not "upgrade" from 2.12 to 2.13
+ {
+ matchManagers: ["gradle"],
+ matchPackageNames: [
+ "org.scala-lang:scala-reflect",
+ "org.scala-lang:scala-library",
+ ],
+ "matchCurrentVersion": "/^2\\.12\\./",
+ "allowedVersions": "/^2\\.12\\./"
Review Comment:
This appears to be the only way, but that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]