ajantha-bhat commented on code in PR #4507:
URL: https://github.com/apache/polaris/pull/4507#discussion_r3273988953
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##########
@@ -317,13 +327,33 @@ public void purgeTable(Catalog catalog, TableIdentifier
ident) {
}
}
+ /**
+ * @deprecated since 1.11.0, will be removed in 1.12.0. Use {@link
#loadTable(Catalog,
+ * TableIdentifier, RESTCatalogProperties.SnapshotMode)} instead.
+ */
+ @Deprecated
public LoadTableResponse loadTable(Catalog catalog, TableIdentifier ident) {
+ return loadTable(catalog, ident, RESTCatalogProperties.SnapshotMode.ALL);
Review Comment:
> <p>WARNING: this isn't a full copy of the Iceberg version, but rather, a
cherry-pick of relevant
* functions. For instance, the idempotency store is not copied.
I saw the code comment and assumed that maybe we can just copy only related
functions like "view register". I am not sure about the protocol on this in
Polaris. But if this is the way, then works for me.
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##########
@@ -317,13 +327,33 @@ public void purgeTable(Catalog catalog, TableIdentifier
ident) {
}
}
+ /**
+ * @deprecated since 1.11.0, will be removed in 1.12.0. Use {@link
#loadTable(Catalog,
+ * TableIdentifier, RESTCatalogProperties.SnapshotMode)} instead.
+ */
+ @Deprecated
public LoadTableResponse loadTable(Catalog catalog, TableIdentifier ident) {
+ return loadTable(catalog, ident, RESTCatalogProperties.SnapshotMode.ALL);
Review Comment:
> <p>WARNING: this isn't a full copy of the Iceberg version, but rather, a
cherry-pick of relevant
functions. For instance, the idempotency store is not copied.
I saw the code comment and assumed that maybe we can just copy only related
functions like "view register". I am not sure about the protocol on this in
Polaris. But if this is the way, then works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
