dimas-b commented on code in PR #4499:
URL: https://github.com/apache/polaris/pull/4499#discussion_r3276292495
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -432,6 +432,7 @@ public boolean dropTable(TableIdentifier tableIdentifier,
boolean purge) {
if (!dropEntityResult.isSuccess()) {
switch (dropEntityResult.getReturnStatus()) {
case BaseResult.ReturnStatus.ENTITY_NOT_FOUND:
+ case BaseResult.ReturnStatus.CATALOG_PATH_CANNOT_BE_RESOLVED:
Review Comment:
Looking at javadoc and code sites that produce
`CATALOG_PATH_CANNOT_BE_RESOLVED` is it not apparently that this error code is
equivalent to "not found" 🤷
However, OSS call paths appear to involve `CATALOG_PATH_CANNOT_BE_RESOLVED`
only in case of "in memory" persistence.
All in all, this change appears to be benign, so I'm approving.
It might be worth logging the error and related entity path as a `DEBUG`
message to facilitate troubleshooting in case `CATALOG_PATH_CANNOT_BE_RESOLVED`
happens to result from some other error than "not found".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
