mj006648 commented on PR #4451: URL: https://github.com/apache/polaris/pull/4451#issuecomment-4504344198
Thanks for the second pass, @dimas-b. Pushed a follow-up. For the Trino block (L220): I traced what Polaris actually vends in the LoadTable response. From `polaris-core/src/main/java/org/apache/polaris/core/storage/StorageAccessProperty.java` (lines 41-44) the keys exposed to the client are `s3.endpoint`, `s3.path-style-access`, and `client.region`, populated by `AwsCredentialsStorageIntegration` (lines 172-193) from `endpoint` / `pathStyleAccess` / `region` on the storage config. So I dropped `s3.region` and the separate `s3.endpoint` / `s3.path-style-access` block — those really are redundant on the client. I kept `fs.native-s3.enabled=true` since that flag turns on Trino's native S3 filesystem and isn't something Polaris can vend. Rewrote the surrounding paragraph to reflect that split. L261: replaced `userArn` with `roleArn` (leftover from the first pass — `AwsStorageConfigurationInfo.getRoleARN()` is what gets threaded into the `AssumeRoleRequest`). Diff is +5/-13, docs-only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
