dimas-b commented on code in PR #4422:
URL: https://github.com/apache/polaris/pull/4422#discussion_r3283128243
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -918,6 +952,15 @@ private void validateUpdateCatalogDiffOrThrow(
// New base location is already in the updated properties; we'll also
potentially
// plumb it into the logic for setting an updated
StorageConfigurationInfo.
defaultBaseLocation = newDefaultBaseLocation;
+
+ // If the storage config is not being updated and the location
actually changed,
+ // validate that the new base location is allowed by the existing
storage configuration
+ // to prevent inconsistent state.
+ if (updateRequest.getStorageConfigInfo() == null
+ &&
!newDefaultBaseLocation.equals(currentCatalogEntity.getBaseLocation())) {
Review Comment:
Why bother with a new issue? This PR's title suggests that it intends to
rectify base location validation. It's perfectly fine to adjust previous
behaviours in this context in order to achieve full validation coverage
:thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
