flyrain commented on code in PR #4537:
URL: https://github.com/apache/polaris/pull/4537#discussion_r3312582344
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java:
##########
@@ -202,10 +202,11 @@ public static CredentialAccessBoundary
generateAccessBoundaryRules(
Map<String, List<String>> readConditionsMap = new HashMap<>();
Map<String, List<String>> writeConditionsMap = new HashMap<>();
- HashSet<String> readBuckets = new HashSet<>();
- HashSet<String> writeBuckets = new HashSet<>();
+ LinkedHashSet<String> readBuckets = new LinkedHashSet<>();
+ LinkedHashSet<String> writeBuckets = new LinkedHashSet<>();
Stream.concat(allowedReadLocations.stream(),
allowedWriteLocations.stream())
.distinct()
+ .sorted()
Review Comment:
Worth a one-line comment that `.sorted()` here is for deterministic rule
emission (callers of `generateAccessBoundaryRules` already treat the rules as
order-independent, but the test fixtures now depend on this ordering). Keeps
future readers from "simplifying" it back to a HashSet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
