gh-yzou commented on PR #4535: URL: https://github.com/apache/polaris/pull/4535#issuecomment-4560086468
From my POV, it should be fine to duplicate the SparkCatalog support, since those might change based on spark version. I see @MonkeyCanCode already did some common code extraction which is not going to change based on spark version, such as the Rest request, which is a pretty good staring point, and we can work on better extraction in followup PRs also. Furthermore, this can make support of new version and deprecation of old spark version much easy also. @MonkeyCanCode I think one thing is that, i think @flyrain previously had one suggestion where we want to see if we can retain the commit history for the files copied from 3.5, so that even if we deprecated (deleted) 3.5, we can still see our commit history, not fully sure how easy it would be though. cc @flyrain Overall, i think the current version looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
