snazy commented on code in PR #4552:
URL: https://github.com/apache/polaris/pull/4552#discussion_r3315544333


##########
persistence/nosql/persistence/impl/src/testFixtures/java/org/apache/polaris/persistence/nosql/impl/commits/BaseTestCommitterImpl.java:
##########
@@ -50,6 +54,19 @@ public abstract class BaseTestCommitterImpl {
   @PolarisPersistence(fastRetries = true)
   protected Persistence persistence;
 
+  @Test
+  public void exclusiveSynchronizerDoesNotReleaseUnacquiredPermit() {
+    var sync =
+        ExclusiveCommitSynchronizer.forKey(
+            persistence.realmId(), "exclusiveSynchronizer-" + 
persistence.generateId());
+
+    soft.assertThat(sync.before(0L)).isTrue();
+    soft.assertThat(sync.before(1L)).isFalse();
+    sync.after();

Review Comment:
   Oops, the other way around



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to