snazy commented on code in PR #4190:
URL: https://github.com/apache/polaris/pull/4190#discussion_r3317370702
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -2700,6 +2756,30 @@ private Page<TableIdentifier> listTableLike(
.map(record -> TableIdentifier.of(parentNamespace, record.getName()));
}
+ private Optional<PolarisEntitySubType> conflictingTableLikeSubtype(
+ List<PolarisEntity> catalogPath, String entityName) {
+ for (PolarisEntitySubType subType :
+ List.of(PolarisEntitySubType.ICEBERG_TABLE,
PolarisEntitySubType.ICEBERG_VIEW)) {
Review Comment:
Do we really need _two_ additional `readEntityByName` invocations against
the backend database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
