venkateshwaracholan opened a new pull request, #4582:
URL: https://github.com/apache/polaris/pull/4582
Fixes #4492
## Summary
Add support for Iceberg's `unique-table-location` catalog property when
creating tables without an explicit location.
## Changes
* Honor `CatalogProperties.UNIQUE_TABLE_LOCATION` when computing default
table locations.
* Use Iceberg's `LocationUtil.tableLocation(...)` helper to generate table
directory names.
* Re-enable the previously disabled Iceberg compatibility test
`createTableInUniqueLocation()`.
* Add a changelog entry.
## Validation
Verified Iceberg 1.11 uses the same `LocationUtil.tableLocation(...)` helper
when `unique-table-location` is enabled.
Ran:
```bash
./gradlew :polaris-runtime-service:test \
--tests
"org.apache.polaris.service.catalog.iceberg.IcebergCatalogRelationalTest.createTableInUniqueLocation"
```
Result: passed.
Also ran:
```bash
./gradlew :polaris-runtime-service:spotlessJavaCheck
./gradlew compileAll
```
Both passed.
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected])
- [ ] ๐ Clearly explained why the changes are needed, or linked related
issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and
explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]