venkateshwaracholan commented on PR #4581: URL: https://github.com/apache/polaris/pull/4581#issuecomment-4586939557
> Thanks for your contribution, @venkateshwaracholan ! The change looks correct to me by itself 👍 > > However, I'm not sure we can claim "fixing" #3508 with this PR because the comments on that issue apparently indicate consensus to _not_ publish source archives to GH releases (which this PR does not address, as far as I can tell). > > All in all, I think we can merge this PR without closing #3508 and deal with source and binary archives in GH releases separately. Thanks, @dimas-b. Good point. This change only fixes ZIP artifact uploads and does not address the broader source archive discussion in #3508. I'll update the PR description to reference #3508 without closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
