dimas-b commented on code in PR #4554:
URL: https://github.com/apache/polaris/pull/4554#discussion_r3337258201
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -265,13 +258,17 @@ public void writeToGrantRecords(
QueryGenerator.generateInsertQuery(
ModelGrantRecord.ALL_COLUMNS, ModelGrantRecord.TABLE_NAME,
values, realmId));
} catch (SQLException e) {
+ if (datasourceOperations.isConstraintViolation(e)) {
Review Comment:
Fair enough :+1: Thanks for narrowing the method name to "unique constraint"
violations. Given that we currently have only the PK constraint on this table
this change looks pretty solid to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
