venkateshwaracholan opened a new pull request, #4604:
URL: https://github.com/apache/polaris/pull/4604
Fixes #4601.
Helm CI applied fixture databases and immediately ran ct install, while
local workflows (make helm-fixtures) and developer docs wait for PostgreSQL and
MongoDB pods to become Ready first.
This adds the same kubectl wait steps to CI before chart-testing install.
No production or chart behavior changes.
What changed
After kubectl apply for helm/polaris/ci/fixtures, CI now waits for:
app.kubernetes.io/name=postgres
app.kubernetes.io/name=mongodb
in namespace polaris-ns (120s timeout), matching the selectors already used
in the Makefile and helm-chart/dev.md.
Notes
Fixture YAML confirms both Deployments use these labels, run at replicas: 1,
and define readiness probes โ so --for=condition=ready pod is appropriate.
This aligns CI with documented local practice. It may reduce Helm CI flakes
when persistence scenarios start before databases are accepting connections,
but I have not tied it to a specific past CI failure.
Test plan
CI Helm chart-testing job passes
Verified fixture labels/selectors in:
helm/polaris/ci/fixtures/postgres.yaml
helm/polaris/ci/fixtures/mongodb.yaml
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected])
- [ ] ๐ Clearly explained why the changes are needed, or linked related
issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and
explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
