Copilot commented on code in PR #4625:
URL: https://github.com/apache/polaris/pull/4625#discussion_r3365835171
##########
runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventListeners.java:
##########
@@ -82,6 +74,28 @@ public void onStartup(@Observes StartupEvent event) {
}
}
+ private static EnumSet<PolarisEventType> resolveSupportedTypes(
+ PolarisEventListenerConfiguration.ListenerConfiguration
listenerConfiguration) {
+ // Missing or empty per-listener filters mean that the listener receives
all event types.
+ if (listenerConfiguration == null
+ || (listenerConfiguration.enabledEventCategories().isEmpty()
+ && listenerConfiguration.enabledEventTypes().isEmpty())) {
+ return EnumSet.allOf(PolarisEventType.class);
Review Comment:
The comment says "Missing or empty per-listener filters" but the condition
only checks for missing optionals (and null configuration), not for
present-but-empty sets. This can mislead readers into thinking an explicitly
configured empty list will behave like "all events". Consider rewording the
comment to match the actual behavior (or update the condition if the intent is
truly to treat empty sets as "all").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
