MonkeyCanCode commented on code in PR #4627: URL: https://github.com/apache/polaris/pull/4627#discussion_r3368612093
########## site/content/in-dev/unreleased/getting-started/binary-distribution.md: ########## @@ -52,3 +59,13 @@ You can verify the server is running by checking the health endpoint: ```bash curl http://localhost:8182/q/health ``` + +## Installing the CLI + +Install the Polaris CLI from PyPI: + +```bash +pip install apache-polaris +``` + +The `polaris` command will then be available in your shell. See [Using Polaris]({{% ref "using-polaris" %}}) for usage examples. Review Comment: it is a good idea to use setup polaris cli via pip now as it is published. But looking at https://polaris.apache.org/releases/1.5.0/getting-started/using-polaris/, we are still referring to `./polaris` which is the bash script wrapper and above state `polaris` will be a command instead. ########## site/content/guides/jdbc/docker-compose.yml: ########## @@ -102,6 +104,8 @@ services: condition: service_completed_successfully stdin_open: true tty: true + extra_hosts: Review Comment: Not necessary I think as the guides are using localhost instead? ########## site/content/guides/jdbc/docker-compose.yml: ########## @@ -84,13 +86,13 @@ services: /opt/spark/bin/spark-sql, --packages, "org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.10.1,org.apache.iceberg:iceberg-aws-bundle:1.10.1,org.apache.iceberg:iceberg-gcp-bundle:1.10.1,org.apache.iceberg:iceberg-azure-bundle:1.10.1", --conf, "spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions", - --conf, "spark.sql.catalog.polaris=org.apache.iceberg.spark.SparkCatalog", - --conf, "spark.sql.catalog.polaris.type=rest", - --conf, "spark.sql.catalog.polaris.warehouse=quickstart_catalog", - --conf, "spark.sql.catalog.polaris.uri=http://polaris:8181/api/catalog";, - --conf, "spark.sql.catalog.polaris.credential=root:s3cr3t", - --conf, "spark.sql.catalog.polaris.scope=PRINCIPAL_ROLE:ALL", - --conf, "spark.sql.defaultCatalog=polaris", + --conf, "spark.sql.catalog.quickstart_catalog=org.apache.iceberg.spark.SparkCatalog", Review Comment: is this change necessary? As most of the guides are using `polaris` as catalog name here including jupyter notebook. ########## site/content/in-dev/unreleased/getting-started/using-polaris/_index.md: ########## @@ -44,7 +44,7 @@ Additionally, if Polaris is running somewhere other than `localhost:8181`, you c ### Creating a Principal and Assigning it Privileges -With a catalog created, we can create a [principal]({{% relref "../../entities#principal" %}}) that has access to manage that catalog. For details on how to configure the Polaris CLI, see [the section above](#defining-a-catalog) or refer to the [docs]({{% relref "../../command-line-interface" %}}). +With a catalog created, we can create a [principal]({{% relref "../../entities#principal" %}}) that has access to manage that catalog. For details on how to configure the Polaris CLI, see the [Creating a Catalog]({{% ref "../creating-a-catalog" %}}) page or refer to the [docs]({{% relref "../../command-line-interface" %}}). Review Comment: Should we use `relref` instead to have relative path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
