vigneshio commented on PR #4646: URL: https://github.com/apache/polaris/pull/4646#issuecomment-4648424744
Thanks @nandorKollar , good catch. The rename endpoints define `409` as `"the target identifier to rename to already exists"`, and we already use `409` for that case (`ENTITY_ALREADY_EXISTS` → `AlreadyExistsException`). Mapping a concurrent-modification failure to `409` overloads that meaning, so a spec-compliant client would read it as "already exists" rather than a transient condition. (And my "consistency with `updateTableLike`" reasoning doesn't really apply, since `409` means a commit conflict on the update endpoint but "already exists" on rename.) I've updated the PR to map the concurrency statuses (`TARGET_ENTITY_CONCURRENTLY_MODIFIED`, `ENTITY_CANNOT_BE_RESOLVED`) to `503 ServiceUnavailable`, which the rename spec lists for the transient case, keeping `409` strictly for "already exists". (If Team prefer server-side retry for rename as the original TODO - that'd be a larger change; happy to do it as a follow-up.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
