dimas-b commented on code in PR #4023:
URL: https://github.com/apache/polaris/pull/4023#discussion_r3376448866
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -657,6 +657,18 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
+ public static final FeatureConfiguration<Boolean>
ALLOW_STORAGE_NAME_OVERRIDE =
+ PolarisConfiguration.<Boolean>builder()
+ .key("ALLOW_STORAGE_NAME_OVERRIDE")
+ .description(
+ "If set to true, allows namespaces and tables to set the
polaris.storage.name "
Review Comment:
What is the value of this flag? If a user points to a non-existent storage
name, the adverse effect is localized to that user's change.
Adding storage names is a Catalog Management action and should probably be
covered by AuthZ checks.
I'd think setting/changing `polaris.storage.name` probably needs an new
AuthZ operation rather than a global feature flag.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
