hemasrishalini commented on PR #4636: URL: https://github.com/apache/polaris/pull/4636#issuecomment-4657031044
Thanks for the review! My thinking was that `MetricsRecordConverterTest` provides direct unit test coverage for the conversion logic itself, independent of `PersistingMetricsReporter`, while `PersistingMetricsReporterTest` verifies reporter behavior and persistence interactions. That said, I can see the overlap with the existing reporter tests. If you'd prefer keeping this coverage in `PersistingMetricsReporterTest` instead, I'm happy to move the assertions there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
