hemasrishalini commented on PR #4638:
URL: https://github.com/apache/polaris/pull/4638#issuecomment-4657143279

   Thanks for reviewing.
   
   You're right that these locations would normally be validated earlier 
through `PolarisServiceImpl.validateStorageConfig()` and related checks.
   
   My intention was to add coverage for the defensive validation that still 
exists in `CatalogUtils.validateLocationsForTableLike()`, since the method 
explicitly rejects `file:` and `http:` locations when FILE storage is not 
enabled. I thought it would help guard against regressions if the validation 
flow changes in the future.
   
   That said, I understand the concern about the practical value of this path 
and am happy to follow your recommendation if you think this test isn't needed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to