hemasrishalini commented on PR #4635: URL: https://github.com/apache/polaris/pull/4635#issuecomment-4657429230
Thanks for the review. My intention was to add coverage for utility classes that currently have no dedicated tests. For `IdGeneratorTest`, I was trying to verify the documented contract that generated IDs are non-negative. For `DigestUtilsTest`, I was trying to verify expected SHA-256 output for known inputs. I understand the concern about the value of these test cases, though, and I'm happy to adjust or close the PR if you don't think they're worth keeping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
