adutra opened a new pull request, #4677: URL: https://github.com/apache/polaris/pull/4677
This PR fixes one bug and one flaky test: - `InMemoryBufferEventListener`'s internal cache was using an eviction listener to complete the failed processor. The eviction listener is not the right one: it doesn't trigger when the entry is evicted explicitly. The right listener to use is a removal listener. It's not a big deal because explicit removals generally mean that the processor errored out, or that the application is shutting down; but it's better to go through the listener in all cases. - The test `testProcessorFailureRecovery()` was flaky for two reasons: it was accessing a field on a CDI bean, which is not correct; and it wasn't waiting for the processor to be evicted before sending more events. <!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> ## Checklist - [ ] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
