adnanhemani commented on code in PR #4627:
URL: https://github.com/apache/polaris/pull/4627#discussion_r3383976997


##########
site/content/in-dev/unreleased/getting-started/using-polaris/_index.md:
##########
@@ -150,15 +150,15 @@ _Note: the credentials provided here are those for our 
principal, not the root c
 bin/spark-sql \
 --packages 
org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.10.0,org.apache.iceberg:iceberg-aws-bundle:1.10.0
 \
 --conf 
spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions
 \
---conf spark.sql.catalog.quickstart_catalog.warehouse=quickstart_catalog \
---conf 
spark.sql.catalog.quickstart_catalog.header.X-Iceberg-Access-Delegation=vended-credentials
 \
---conf 
spark.sql.catalog.quickstart_catalog=org.apache.iceberg.spark.SparkCatalog \
---conf 
spark.sql.catalog.quickstart_catalog.catalog-impl=org.apache.iceberg.rest.RESTCatalog
 \
---conf 
spark.sql.catalog.quickstart_catalog.uri=http://localhost:8181/api/catalog \
---conf 
spark.sql.catalog.quickstart_catalog.credential=${USER_CLIENT_ID}:${USER_CLIENT_SECRET}
 \
---conf spark.sql.catalog.quickstart_catalog.scope='PRINCIPAL_ROLE:ALL' \
---conf spark.sql.catalog.quickstart_catalog.token-refresh-enabled=true \
---conf spark.sql.catalog.quickstart_catalog.client.region=us-west-2
+--conf spark.sql.catalog.polaris.warehouse=quickstart_catalog \

Review Comment:
   Yes but then the instructions in the Spark SQL do not work OOTB regardless 
of the way you started Spark - which is exactly where there was confusion by 
users who do not understand Spark configurations well. That's why I see this as 
a required change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to