MonkeyCanCode commented on issue #4663: URL: https://github.com/apache/polaris/issues/4663#issuecomment-4666788569
Hello @jbonofre / @flyrain / @dimas-b , Looking at the license/notice for spark client (both 3 and 4), they are actually the same as there is no change of dependencies. So the current one for spark 4 should be valid is spark 3 is valid. While doing this exercise, I noticed the following potential "issues": 1. Missing notice We are missing notice for `datasketches-java` (it is from Iceberg) and FastDoubleParser from jack (this one is partially included from Jackson). Do we need to implicitly add those or will the current one be sufficient? 2. Missing license We are missing license for Schubfach (used by Jackson). Do we need to implicitly add those or will the current one be sufficient? Beside these 2, we should be okay with the license for spark 4. The only thing which we may want to discuss is https://github.com/apache/polaris/blob/14e2871bf6bc6062e5784aa73dff4113f095d17d/plugins/spark/v4.0/spark/BUNDLE-LICENSE#L207-L208 which they are a bit diff now compared to the one in spark 3.5. Do we still classify them as used from Iceberg? Thanks, Yong Zheng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
