snazy commented on code in PR #4680:
URL: https://github.com/apache/polaris/pull/4680#discussion_r3389050999


##########
Makefile:
##########
@@ -157,8 +157,7 @@ client-setup-env: $(VENV_DIR) ## Set up Python client 
environment (venv + depend
        @$(ACTIVATE_AND_CD) && uv lock && uv sync --active --all-extras
        @echo "--- Python client environment setup complete ---"
 
-.PHONY: client-integration-test
-client-integration-test: build-server client-setup-env ## Run client 
integration tests
+_client-integration-test: client-setup-env

Review Comment:
   That's what `client-integration-test` is already doing.
   
   The new Makefile goal is there to skip the `build-server` goal, which is 
what the PR is about to save. But that's nothing a "normal user" should use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to