hemasrishalini commented on code in PR #4637: URL: https://github.com/apache/polaris/pull/4637#discussion_r3407565366
########## runtime/service/src/test/java/org/apache/polaris/service/auth/internal/service/OAuthUtilsTest.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.auth.internal.service; + +import jakarta.ws.rs.core.Response; +import org.assertj.core.api.Assertions; +import org.assertj.core.api.InstanceOfAssertFactories; +import org.junit.jupiter.api.Test; + +class OAuthUtilsTest { + + @Test + void testUnauthorizedClientResponse() { + Response response = OAuthUtils.getResponseFromError(OAuthError.unauthorized_client); + + Assertions.assertThat(response.getStatus()) + .isEqualTo(Response.Status.UNAUTHORIZED.getStatusCode()); + + Assertions.assertThat(response.getEntity()) + .isInstanceOf(OAuthTokenErrorResponse.class) + .asInstanceOf(InstanceOfAssertFactories.type(OAuthTokenErrorResponse.class)) + .returns(OAuthError.unauthorized_client.name(), OAuthTokenErrorResponse::getError); + } + + @Test + void testInvalidClientResponse() { + assertBadRequest(OAuthError.invalid_client); Review Comment: @dimas-b Thanks for the review and feedback! My intention was to improve coverage around the OAuth error to response mapping, including the default branch and validation of the returned error response. I understand the concern that the test closely mirrors the implementation and may provide limited value given the simplicity of the mapping logic. I'm happy to defer to the maintainers' judgment on whether this coverage is worthwhile to keep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
