bowsii opened a new issue, #4754:
URL: https://github.com/apache/polaris/issues/4754

   ### Is your feature request related to a problem? Please describe.
   
   ### Description
   
   Several JDBC property keys are currently referenced as string literals in 
multiple locations throughout the codebase.
   
   Using repeated string literals for the same property names can make the code 
harder to maintain and increases the risk of inconsistencies or typographical 
errors when updates are required. Extracting these values into shared constants 
would improve readability and make future changes easier.
   
   ### Proposed Change
   
   Identify JDBC property key literals that are used in multiple places and 
replace them with shared constants defined in an appropriate common location.
   
   ### Benefits
   
   - Reduces duplication of string literals.
   - Improves code readability and maintainability.
   - Prevents accidental typos and inconsistencies.
   - Centralizes JDBC property definitions.
   - Makes future refactoring easier.
   
   ### Example
   
   Current:
   
   ```java
   properties.put("jdbc.user", user);
   config.get("jdbc.user");
   
   ### Describe the solution you'd like
   
   Several JDBC property keys appear to be referenced as repeated string 
literals throughout the codebase.
   
   To improve maintainability and reduce duplication, commonly used JDBC 
property keys could be extracted into shared constants and reused wherever 
applicable.
   
   For example:
   
   Current:
   
   ```java
   properties.put("jdbc.user", user);
   config.get("jdbc.user");
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to