adutra commented on code in PR #4745:
URL: https://github.com/apache/polaris/pull/4745#discussion_r3412067529
##########
extensions/auth/opa/tests/src/intTest/java/org/apache/polaris/extension/auth/opa/test/OpaTestProfiles.java:
##########
@@ -35,16 +34,15 @@ private OpaTestProfiles() {}
public static class StaticToken implements QuarkusTestProfile {
@Override
public Map<String, String> getConfigOverrides() {
- Map<String, String> config = new HashMap<>();
- config.put("polaris.authorization.type", "opa");
- config.put("polaris.authorization.opa.auth.type", "bearer");
- config.put(
- "polaris.authorization.opa.auth.bearer.static-token.value",
- "test-opa-bearer-token-12345");
- config.put("polaris.features.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
"[\"FILE\"]");
- config.put("polaris.features.\"ALLOW_INSECURE_STORAGE_TYPES\"", "true");
- config.put("polaris.readiness.ignore-severe-issues", "true");
- return config;
+ return Map.ofEntries(
Review Comment:
Why not use `Map.of()`?
```java
Map.of(
"polaris.authorization.type", "opa",
"polaris.authorization.opa.auth.type", "bearer",
"polaris.authorization.opa.auth.bearer.static-token.value",
"test-opa-bearer-token-12345",
"polaris.features.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
"[\"FILE\"]",
"polaris.features.\"ALLOW_INSECURE_STORAGE_TYPES\"", "true",
"polaris.readiness.ignore-severe-issues", "true");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
