ayushtkn commented on code in PR #4779:
URL: https://github.com/apache/polaris/pull/4779#discussion_r3415310907


##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/generic/GenericTableCatalogHandler.java:
##########
@@ -131,7 +131,7 @@ public LoadGenericTableResponse createGenericTable(
 
   public boolean dropGenericTable(TableIdentifier identifier) {
     PolarisAuthorizableOperation op = 
PolarisAuthorizableOperation.DROP_TABLE_WITHOUT_PURGE;
-    authorizeCreateTableLikeUnderNamespaceOperationOrThrow(op, identifier);
+    authorizeBasicTableLikeOperationOrThrow(op, 
PolarisEntitySubType.GENERIC_TABLE, identifier);
 
     return this.genericTableCatalog.dropGenericTable(identifier);
   }

Review Comment:
   for drop the table should exist only, if it doesn't exist, that seems 
problem only it is same behaviour as in IcebergCatalog



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to