ayushtkn commented on code in PR #4730:
URL: https://github.com/apache/polaris/pull/4730#discussion_r3418314406


##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewIntegrationBase.java:
##########
@@ -124,6 +124,7 @@ public void before(TestInfo testInfo) {
             .addProperty(
                 
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(), "true")
             
.addProperty(FeatureConfiguration.DROP_WITH_PURGE_ENABLED.catalogConfig(), 
"true")
+            
.addProperty(FeatureConfiguration.PURGE_VIEW_METADATA_ON_DROP.catalogConfig(), 
"false")

Review Comment:
   There is a test in base class which sets it to false
   
https://github.com/apache/iceberg/blob/6976e020b894f6a6777704df2b8c4458cb291ae9/core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java#L2028
   
   If you say I can copy the test and change the value just there. Whichever 
way you say



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to