snazy commented on code in PR #4790:
URL: https://github.com/apache/polaris/pull/4790#discussion_r3419109972
##########
runtime/service/src/intTest/java/org/apache/polaris/service/it/RestCatalogMinIOSpecialIT.java:
##########
@@ -124,27 +136,24 @@ public class RestCatalogMinIOSpecialIT {
private PrincipalWithCredentials principalCredentials;
private String catalogName;
- @BeforeAll
- static void setup(
- PolarisApiEndpoints apiEndpoints,
- @Minio(accessKey = ACCESS_KEY, secretKey = SECRET_KEY) MinioAccess
minioAccess,
- ClientCredentials credentials) {
- s3Client = minioAccess.s3Client();
- endpoints = apiEndpoints;
- client = polarisClient(endpoints);
- adminToken = client.obtainToken(credentials);
- managementApi = client.managementApi(adminToken);
- storageBase = minioAccess.s3BucketUri(BUCKET_URI_PREFIX);
- endpoint = minioAccess.s3endpoint();
- }
-
@AfterAll
static void close() throws Exception {
client.close();
}
@BeforeEach
- public void before(TestInfo testInfo) {
+ public void before(
+ TestInfo testInfo, PolarisApiEndpoints apiEndpoints, ClientCredentials
credentials) {
+ if (initialized.compareAndSet(false, true)) {
Review Comment:
PolarisRestCatalogMinIOIT + PolarisRestCatalogMinIOIT use MinIO.
So this change shares the Minio container across those.
Same for RustFS, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
