vigneshio opened a new pull request, #4793: URL: https://github.com/apache/polaris/pull/4793
## Summary This change improves error messages when deleting catalogs, principals, and roles. Previously, all delete failures were reported using messages meant for protected roles or admin roles, even when the real problem was something else. For example, if a normal principal like `alice` was deleted while being updated concurrently, the API could return: > "Root principal cannot be dropped, concurrent modification detected. Please try again" That message incorrectly identifies `alice` as the root principal. Now, each delete failure type returns a more accurate error: * Protected/root/admin entities keep their existing messages. * Concurrent modification errors mention the actual entity being modified. * Missing entities return a "not found" error. * Non-empty catalogs or namespaces return the appropriate "not empty" error. * Unknown failures return a generic message that includes the failure status. --- ## Checklist * [ ] Don't disclose security issues! (contact [email protected]) * [x] Clearly explained why the changes are needed, or linked related issues. * [x] Added/updated tests with good coverage, or manually tested (and explained how) * [ ] Added comments for complex logic * [x] Updated `CHANGELOG.md` (if needed) * [ ] Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
