flyrain commented on code in PR #4666:
URL: https://github.com/apache/polaris/pull/4666#discussion_r3385996960
##########
plugins/spark/v4.0/integration/build.gradle.kts:
##########
@@ -146,7 +146,7 @@ dependencies {
// Spark 4.0 requires version 5.0.0 which includes SingleThreadModel
// Quarkus BOM forces it to 6.x which removed SingleThreadModel
configurations.named("intTestRuntimeClasspath") {
- resolutionStrategy { force("jakarta.servlet:jakarta.servlet-api:5.0.0") }
+ resolutionStrategy { force("jakarta.servlet:jakarta.servlet-api:6.1.0") }
Review Comment:
This force pins servlet-api *down* to 5.0.0 on purpose (see comment just
above: 6.x removed SingleThreadModel that Spark 4.0 needs). Forcing 6.1.0
reintroduces exactly what the override was added to avoid and will likely break
intTest. I think we may change the renovate rule for this to avoid new PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
