dimas-b commented on code in PR #4815:
URL: https://github.com/apache/polaris/pull/4815#discussion_r3431284080


##########
runtime/admin/src/main/java/org/apache/polaris/admintool/BootstrapCommand.java:
##########
@@ -91,9 +91,20 @@ static class SchemaInputOptions {
       @CommandLine.Option(
           names = {"-v", "--schema-version"},
           paramLabel = "<schema version>",
+          converter = SchemaVersionConverter.class,
           description = "The version of the schema to load in [1, 2, 3, 
LATEST].")

Review Comment:
   TBH, I'm not sure `LATEST` here was ever meant to be a literal value 🙂 
   
   I'd rather rephrase the description to something like `The version of the 
schema to load. The set of valid values depends on the backend type. If omitted 
the latest schema version will be used.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to