adutra commented on code in PR #4755:
URL: https://github.com/apache/polaris/pull/4755#discussion_r3437221354
##########
helm/polaris/values.yaml:
##########
@@ -1167,3 +1167,104 @@ tasks:
# -- The maximum number of tasks that can be queued up for execution. If
unspecified or zero, defaults to Integer.MAX_VALUE.
# @section -- Tasks
maxQueuedTasks: 0 # 1000
+
+# @schema type: object
+# -- Configuration for maintenance tasks using as Kubernetes CronJob
+# @section -- Maintenance
+maintenance:
+ # @schema additionalProperties: {type: string}
+ # -- Annotations to add to every maintenance Cronjob object.
+ # @section -- Maintenance
+ annotations: {}
+
+ # @schema item: object
+ # -- Extra environment variables to add to every maintenance Cronjob object.
+ # @section -- Maintenance
+ extraEnv: []
Review Comment:
Yes, I agree with your reasoning. But in this case, let's document each
field and clearly state that they are NOT merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
